add windows icon

[mrbesen]

I added the stuff required to give the exe file an icon.

The problem: It increases the filesize from 69.1kB to 208.4kB - Wtf?
I dont know if thats worth for you. Maybe you want to provide both, a icon exe file and an non icon exe file?
It might be possible to reduce the exe filesize by removing some icon resolutions. I don't know which are required.

[dreua]

I don't care about the file size its still probably the smallest application I'd use on windows. But that is on @cnlohr to decide.

The ci fails here, probably needs to run the icon building prior to the exe building. Should be fixable in Makefile.

[dreua]

I always think icons are an improvement BTW 👍

[mrbesen]

I have removed all icon sizes except 128px and 32px. But i dont know if windows requires some sizes inbetween for correct display. But the binary is now "only" 140kB

[dreua]

Lgtm, not tested in Windows yet

[cnlohr]

I don't see the actual .ico file in this CL.

[dreua]

I don't see the actual .ico file in this CL.

Its generated from the svg by Makefile instructions, looks like this. It's good enough to be something distinctive and doesn't look broken :)

[cnlohr]

Please also check it in as an artifact

[mrbesen]

I have now manually compressed the icon using Gimp. The ico is now only 1.7kB!
I did not find an appropriate imagemagick command to do the same thing. So i just commited the compressed ico file to the repo and wrote the steps i took to compress the image in the Makefile.

On my windows11 system the created exe with icon looks great. But gimp warns about using compression. Maybe older windows systems have problems with that. What's the oldest windows we want to support? If windows is not able to load the compressed icon would the application still work? I can check if i have an winXP or Win7 vm where i can test that.

EDIT:

I tested it on winXP and win7 vms.

winXP:

the icon is not displayed in the compressed version, but cnping does not work at all.
It only creates this error:

cnping.exe - Entry Point Not Found
The procedure entry point RegGetValueA could not be located in the dynamic link library ADVAPI32.dll.

win7:

The icon is displayed in compressed and uncompressed forms. cnping does start, but is crashing after creating the window. I belive its the same bug as in #83 .
But i guess it doesnt matter for this PR, as the icon does not make anything worse than it is without.

[dreua]

As we are now committing this file, I'd say we shouldn't require it here to avoid confusion

[mrbesen]

i have removed it by editing the commit
from e4c2dc6
to fix ci; reduce amount of resolutions

[dreua]

Never mind my comment about artifacts, you already removed that part again in the last commit 👍

[cnlohr]

I am good with this at this point. @dreua do you feel it's ready?

[dreua]

Haven't tested it myself but I trust mrbesen's tests, ready to merge from my side.