Check in initial e2e tests for cloud operator. #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarp
force-pushed
the
jmcarp/poc-deploy-operator-e2e
branch
3 times, most recently
from
9990a05 to
304c916
Compare
Add an e2e test that installs the operator, then a crdbcluster, and makes assertions about basic crdb functionality.
jmcarp
force-pushed
the
jmcarp/poc-deploy-operator-e2e
branch
from
304c916 to
fcb5c37
Compare
pritesh-lahoti
approved these changes
Jan 20, 2025
|
|
||
| if rotate { | ||
| t.Log("Verifying the existing data in the database after certificate rotation") | ||
| } | ||
|
|
||
| // Create database only if we are testing crdb install | ||
| if !rotate { | ||
| if _, err := db.Exec("CREATE DATABASE test_db"); err != nil { | ||
| if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS testdb"); err != nil { |
There was a problem hiding this comment.
Suggested change
| if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS testdb"); err != nil { | |
| if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS test_db"); err != nil { |
Looks like this is causing the test to fail on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to deploy the operator, then a single-node crdb cluster, and test basic functionality.