Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of SpriteAtlas after setting up a SpriteFrame in Sprite #18108

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Jan 2, 2025

Re: #

https://forum.cocos.org/t/topic/163455/388

Changelog

  1. Remove _applyAtlas from the engine code and handle it in the Editor Sprite inspector panel instead.
    2.Dependent atlas asset are only set if the user sets a SpriteFrame

Since the SpriteFrame's atlasUuid is null when using auto-atlas, the meta importer is the auto-atlas asset by up-querying for a suffix of .pac


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@knoxHuang knoxHuang requested review from wuzhiming and minggo January 2, 2025 02:12
Copy link

github-actions bot commented Jan 2, 2025

👍 Package size ⤵ -18 bytes, old: 5280433, new: 5280415

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS PASS

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS PASS
wechatgame PASS PASS FAIL dynamic-mesh dynamic-mesh

@minggo minggo merged commit 3307c3a into cocos:v3.8.6 Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants