Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to portal #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updates to portal #1

wants to merge 2 commits into from

Conversation

JakeNeyer
Copy link 

* Export both active and inactive customers
* Add additional fields to volunteer export (email, first name, last name, last job, end reason, and end date)
* Add ability to make volunteers active/inactive
* Remove empty pages from generated route report
* Add meal and client count to job overview page
* Sort customers in reports alphabetically
* Add database seed script to load db with fake data for local development

@JakeNeyer
Updates to portal
d4db658 
    * Export both active and inactive customers
    * Add additional fields to volunteer export (email, first name, last name, last job, end reason, and end date)
    * Add ability to make volunteers active/inactive
    * Remove empty pages from generated route report
    * Add meal and client count to job overview page
    * Sort customers in reports alphabetically
@JakeNeyer
Copy link
Author

@awhicks tagging you for review

awhicks
awhicks approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@awhicks awhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a couple small comments that you don't need to address, just information!

src/pdfs/views.py Outdated
@@ -321,6 +343,7 @@ def monthly_billing_report(request, begin_date, end_date):
date__lte=end_date) .values("date") .annotate(
total_meals=Sum("num_meals")) .order_by("date"))

print(date_meals_query)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need this!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that 🙃

src/models/management/commands/seed.py
@@ -0,0 +1,120 @@
from django.core.management.base import BaseCommand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with this, but I think we do have some sample data, it just doesn't have a nice wrapper around if you were looking for something else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awhicks awhicks awhicks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeNeyer @awhicks