Appless non-PAT org dropdown clarity changes #3628
Conversation
Bundle ReportChanges will increase total bundle size by 370 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 370 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## cy/non_pat_appless #3628 +/- ##
===================================================
Coverage 98.98% 98.98%
===================================================
Files 810 810
Lines 14562 14568 +6
Branches 4141 4153 +12
===================================================
+ Hits 14414 14420 +6
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## cy/non_pat_appless #3628 +/- ##
===================================================
Coverage 98.98% 98.98%
===================================================
Files 810 810
Lines 14562 14568 +6
Branches 4148 4153 +5
===================================================
+ Hits 14414 14420 +6
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## cy/non_pat_appless #3628 +/- ##
===================================================
Coverage 98.98% 98.98%
===================================================
Files 810 810
Lines 14562 14568 +6
Branches 4148 4153 +5
===================================================
+ Hits 14414 14420 +6
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## cy/non_pat_appless #3628 +/- ##
===================================================
Coverage 98.98% 98.98%
===================================================
Files 810 810
Lines 14562 14568 +6
Branches 4141 4153 +12
===================================================
+ Hits 14414 14420 +6
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
calvin-codecov
force-pushed
the
cy/org_dropdown_changes
branch
from
dc3ee2a to
36c4e50
Compare
| <p className="ml-1"> | ||
| {displayUsername} | ||
| {displayUsername === currentUserUsername | ||
| ? "'s personal organization" | ||
| : ''} | ||
| </p> |
There was a problem hiding this comment.
I was playing around with this a little, because the current styles feel a bit much for all this text:
I came up with two tiny alternatives that are fairly quick changes, the first removing the boldness and making it a little smaller:
And the second just removing the boldness:
Let me know what you think of these!
There was a problem hiding this comment.
I like the last one! Would that work for, @Adal3n3 ?
There was a problem hiding this comment.
@nicholas-codecov @calvin-codecov Thanks for showing different variation of the "personal org" font style. After playing around the actual one in this pr, I prefer the first option as it looks consistent and smooth where second and third look a bit busy. If that's ok, please use the first option.
Description
Closes codecov/engineering-team#2734
Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=Ae9VxfEVoCH7C8je-1
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.