-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: background color on trend selector container for dark mode #3641
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportChanges will increase total bundle size by 6.14MB (50.87%) ⬆️
ℹ️ *Bundle size includes cached data from a previous commit |
Bundle ReportChanges will increase total bundle size by 30 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 98.98% 98.95% -0.04%
==========================================
Files 811 811
Lines 14541 14575 +34
Branches 4127 4145 +18
==========================================
+ Hits 14393 14422 +29
- Misses 141 146 +5
Partials 7 7
... and 16 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 98.98% 98.95% -0.04%
==========================================
Files 811 811
Lines 14541 14575 +34
Branches 4127 4138 +11
==========================================
+ Hits 14393 14422 +29
- Misses 141 146 +5
Partials 7 7
... and 16 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 98.98% 98.95% -0.04%
==========================================
Files 811 811
Lines 14541 14575 +34
Branches 4127 4145 +18
==========================================
+ Hits 14393 14422 +29
- Misses 141 146 +5
Partials 7 7
... and 16 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 98.98% 98.95% -0.04%
==========================================
Files 811 811
Lines 14541 14575 +34
Branches 4127 4145 +18
==========================================
+ Hits 14393 14422 +29
- Misses 141 146 +5
Partials 7 7
... and 16 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Description
This PR fixes a background style on the trend selector elements for both the coverage overview and bundle overview pages.
Just settings it to transparent, pics before and after.
Screenshots
COVERAGE PAGE
BUNDLE PAGE
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.