Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background color on trend selector container for dark mode #3641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Jan 8, 2025

Description

This PR fixes a background style on the trend selector elements for both the coverage overview and bundle overview pages.

Just settings it to transparent, pics before and after.

Screenshots

COVERAGE PAGE
Screenshot 2025-01-08 at 2 54 00 PM
Screenshot 2025-01-08 at 2 53 50 PM

BUNDLE PAGE
Screenshot 2025-01-08 at 2 59 16 PM
Screenshot 2025-01-08 at 2 59 06 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 6.14MB (50.87%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
gazebo-staging-array-push* 6.14MB 6.14MB (100%) ⬆️⚠️
gazebo-staging-system-esm 6.06MB 15 bytes (0.0%) ⬆️
gazebo-staging-system 6.0MB 15 bytes (0.0%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 30 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 15 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.06MB 15 bytes (0.0%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (113a97f) to head (2bb726b).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   98.98%   98.95%   -0.04%     
==========================================
  Files         811      811              
  Lines       14541    14575      +34     
  Branches     4127     4145      +18     
==========================================
+ Hits        14393    14422      +29     
- Misses        141      146       +5     
  Partials        7        7              
Files with missing lines Coverage Δ
src/ui/Select/Select.jsx 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.06%) ⬇️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113a97f...2bb726b. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (113a97f) to head (2bb726b).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   98.98%   98.95%   -0.04%     
==========================================
  Files         811      811              
  Lines       14541    14575      +34     
  Branches     4127     4138      +11     
==========================================
+ Hits        14393    14422      +29     
- Misses        141      146       +5     
  Partials        7        7              
Files with missing lines Coverage Δ
src/ui/Select/Select.jsx 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.06%) ⬇️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113a97f...2bb726b. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (113a97f) to head (2bb726b).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   98.98%   98.95%   -0.04%     
==========================================
  Files         811      811              
  Lines       14541    14575      +34     
  Branches     4127     4145      +18     
==========================================
+ Hits        14393    14422      +29     
- Misses        141      146       +5     
  Partials        7        7              
Files with missing lines Coverage Δ
src/ui/Select/Select.jsx 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.06%) ⬇️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113a97f...2bb726b. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
2bb726b Wed, 08 Jan 2025 23:08:24 GMT Cloud Enterprise

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
- Coverage   98.98%   98.95%   -0.04%     
==========================================
  Files         811      811              
  Lines       14541    14575      +34     
  Branches     4127     4145      +18     
==========================================
+ Hits        14393    14422      +29     
- Misses        141      146       +5     
  Partials        7        7              
Files with missing lines Coverage Δ
src/ui/Select/Select.jsx 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.06%) ⬇️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113a97f...2bb726b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants