fix: update isPaid condition for course stages #2576
Conversation
Adjust the isPaid condition to include courses at position 3. This change ensures that the correct payment status is applied to courses that are at the third position or higher.
WalkthroughThe pull request modifies the Changes
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
mirage/utils/create-course-from-data.js (1)
101-101: Document the business rule with a comment.Consider adding a comment to explain why stage 3 and above are paid stages. This helps maintain the business logic in the test fixtures.
- isPaid: positionWithinCourse >= 3, + // Stages 3 and above require payment + isPaid: positionWithinCourse >= 3,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
mirage/utils/create-course-from-data.js(1 hunks)
🔇 Additional comments (1)
mirage/utils/create-course-from-data.js (1)
101-101: Verify test coverage for stage 3 payment status.The change to include stage 3 as a paid stage (
>= 3instead of> 3) aligns with the PR objectives. However, we should verify that existing tests aren't assuming stage 3 is free.✅ Verification successful
Change to include stage 3 as paid appears safe for existing tests
The codebase's test suite focuses on verifying the presence of upgrade prompts for paid stages without making assumptions about specific stage numbers. No tests were found that explicitly depend on stage 3 being free.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for tests that might be assuming stage 3 is free rg -l "stage.*3.*free|stage.*3.*paid|isPaid.*3" tests/Length of output: 56
Script:
#!/bin/bash # Search for test files that work with courses and stages echo "=== Tests mentioning courses or stages ===" rg -l "course|stage" tests/ echo -e "\n=== Mirage factory usage ===" rg -l "createCourse" tests/ echo -e "\n=== Payment status checks in tests ===" rg "assert.*paid|paid.*assert|isPaid" tests/Length of output: 8485
Adjust the isPaid condition to include courses at position 3. This
change ensures that the correct payment status is applied to
courses that are at the third position or higher.
Summary by CodeRabbit