Add first-party support for & setup tests against zsh and dash
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Makefile for improved readability and maintainability
…roved clarity and maintainability
…eted paste support
…proved clarity; implement quoting function for stage arrays
…Alpine; add git config setup step
ryan-gang
force-pushed
the
add-secondary-shells
branch
from
fe0ec29 to
c7497ab
Compare
ryan-gang
changed the title
zsh and dashzsh and dash
ryan-gang
force-pushed
the
add-secondary-shells
branch
from
7df993f to
bcd8e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the testing workflows, Makefile, and internal test cases to support multiple shell environments and improve test coverage. The key changes include modifications to the GitHub Actions workflows, updates to the Makefile for new test targets and stages, and enhancements to the test cases to handle different shell-specific behaviors.
Workflow and Makefile updates:
.github/workflows/test.yml: Renamedtest-alpinejob totest-all-shellsand added steps to install and test multiple shells, including bash, dash, and zsh. [1] [2] [3]Makefile: Addedtests_excluding_ashtarget to exclude ash from tests and restructured stage definitions usingdefineandendeffor better readability and maintenance. [1] [2] [3]Test case enhancements:
internal/stage10.go: Added fallback patterns for dash and zsh to handle directory change errors.internal/stage_q4.go: Simplified test case creation and added fallback patterns for expected outputs. [1] [2]internal/stage_q5.go: Corrected expected output for quoting test cases.Test coverage improvements:
internal/stages_test.go: Expanded test cases to include separate scenarios for bash and ash, ensuring comprehensive coverage across different shells. [1] [2]internal/test_cases/invalid_command_test_case.go: Added fallback patterns for zsh and dash to handle invalid command errors.