Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bill follow and unfollow functionality to testimony page #1661

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aaerhart
Copy link
Collaborator

Summary

#1652 A functional click event with a request and resposne has been added to the Follow bill button in the menu on the Testimony Detail page for each testimony.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Screenshot 2024-12-17 at 5 44 51 PM Screenshot 2024-12-17 at 5 44 46 PM

Known issues

Steps to test/reproduce

  1. Go to the list of testimonies page, accessed from either the nav option or the page main section link option
  2. Click on and go to the Testimony Detail page
  3. Click on Follow button, should now read "Unfollow", action should work for following/unfollowing. See testimonies linked to the same bill should read the same for the button.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:09am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple of nits. Thanks for taking this on!

signOut={signOutAndRedirectToHome}
/>
</PageContainer>
<FollowContext.Provider value={{ followStatus, setFollowStatus }}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We maintain a list of providers in components/providers.tsx that keeps a central point of access for all of our core context providers - it might make sense to add this as a Provider there to help keep our providers organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants