fix: cloudcmd: make manifest.json accessible when authentication is e…

…nabled (#428) * Make manifest.json accessable when authentication is enabled * add test for manifest.json availability when authentication is enabled
coderaiser · Nov 22, 2024 · dff0267 · dff0267
1 parent 03e3ba6
commit dff0267
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/html/index.html b/html/index.html
@@ -9,7 +9,7 @@
         <link rel="icon" href="{{ prefix }}/favicon.ico">
 
         <link rel=stylesheet href="{{ prefix }}/dist/cloudcmd.css">
-        <link rel="manifest" href="{{ prefix }}/static/manifest.json">
+        <link rel="manifest" href="{{ prefix }}/public/manifest.json">
         <noscript>
             <link rel=stylesheet href="{{ prefix }}/dist/nojs.css">
         </noscript>

diff --git a/static/manifest.json → public/manifest.json b/static/manifest.json → public/manifest.json
diff --git a/server/auth.js b/server/auth.js
@@ -17,7 +17,7 @@ module.exports = (config) => {
 function _middle(config, authentication, req, res, next) {
     const is = config('auth');
 
-    if (!is)
+    if (!is || req.originalUrl.startsWith("/public/"))
         return next();
 
     const success = () => next();

diff --git a/server/cloudcmd.spec.mjs b/server/cloudcmd.spec.mjs
@@ -178,3 +178,20 @@ test('cloudcmd: sw', async (t) => {
     t.equal(status, 200, 'should return sw');
     t.end();
 });
+
+test('cloudcmd: manifest.json', async (t) => {
+    const config = {
+        auth: true,
+    };
+
+    const options = {
+        config,
+    };       
+
+    const {status} = await request.get('/public/manifest.json', {
+        options,
+    });
+
+    t.equal(status, 200, 'should return manifest.json even when authentication is enabled');
+    t.end();
+});