Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adapt README to crates.io #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Razaloc
Copy link
Contributor

@Razaloc Razaloc commented Dec 19, 2022

At this moment bmap-rs and bmap-parser share the same README. This is problematic because in crates.io, once published, bmap-parser contains references to bmap-rs while if should be independent from it.

Fix the original README file.
Add a new README file for bmap-parser.

Signed-off-by: Rafael Garcia Ruiz [email protected]

@Razaloc Razaloc force-pushed the wip/rafaelgarrui/bmap-parserreadme branch from 102b612 to fa8e7f5 Compare December 19, 2022 14:12
@Razaloc
Copy link
Contributor Author

Razaloc commented Dec 19, 2022

Just in case we want to quick fix the README problem, I've committed a bump to versions.

bmap-parser/README.md Outdated Show resolved Hide resolved
@Razaloc Razaloc force-pushed the wip/rafaelgarrui/bmap-parserreadme branch from 026ccf0 to 6724966 Compare December 19, 2022 14:35
@Razaloc Razaloc changed the title doc: adapt README to crates.io docs: adapt README to crates.io Dec 21, 2022
@Razaloc Razaloc force-pushed the wip/rafaelgarrui/bmap-parserreadme branch from 6724966 to e87c049 Compare January 19, 2023 12:22
@Razaloc Razaloc mentioned this pull request Feb 17, 2023
@obbardc
Copy link
Contributor

obbardc commented Feb 18, 2023

can you drop the bors commit and the version bump commit ?
We are gonna drop bors at some point, and I think we should handle the release separately.

bmap-rs and bmap-parser share the same README at this moment. This is
problematic because in crates.io once published bmap-parser contains
references to bmap-rs while if should be independent of it.

Fix the original README file.
Add a new README file for bmap-parser.

Signed-off-by: Rafael Garcia Ruiz <[email protected]>
Explain context information for understanding bmap and bmap-rs.
Most of this information has been obtain and adapted from;
https://github.com/intel/bmap-tools/blob/master/README.md

Signed-off-by: Rafael Garcia Ruiz <[email protected]>
Uses a more standard reference to the license recommended by the rust
documentation (https://rust-lang.github.io/api-guidelines/necessities.html)

Signed-off-by: Rafael Garcia Ruiz <[email protected]>
@Razaloc Razaloc force-pushed the wip/rafaelgarrui/bmap-parserreadme branch from fb1b0f0 to 509aa95 Compare February 20, 2023 09:41
@Razaloc Razaloc requested a review from obbardc February 20, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants