Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable servant #5721

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Reenable servant #5721

merged 1 commit into from
Nov 7, 2020

Conversation

maksbotan
Copy link
Contributor

@maksbotan maksbotan commented Nov 4, 2020

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, you have successfully run the following command (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    ./verify-package $package # or $package-$version
    

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version  # $version is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

Note that some of these packages have Hackage revisions that fix version bounds.

I'm going to update the rest of Servant family in the next few days.

Fixes haskell-servant/servant#1340

@maksbotan maksbotan force-pushed the servant branch 2 times, most recently from 481bde5 to c31cf72 Compare November 5, 2020 12:41
@jkachmar jkachmar merged commit 5dc6c1d into commercialhaskell:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add servant back to stackage
2 participants