Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for custom DNS in Nextcloud install script #143

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

remz1337
Copy link
Contributor

@remz1337 remz1337 commented Nov 8, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Fix in nextcloud script has been deployed, so we don't need anymore the custom DNS hack.

Tested and working on my side
nextcloud/nextcloudpi#2004
nextcloud/nextcloudpi#1926

Fixes # (issue)
#94

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)
  • Documentation update required (this change requires an update to the documentation)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)

@remz1337 remz1337 requested a review from a team as a code owner November 8, 2024 22:07
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

@newzealandpaul newzealandpaul merged commit 6afb28f into community-scripts:main Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants