add mailgun setup #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Suraci <[email protected]> Co-authored-by: Taylor Silva <[email protected]>
aoldershaw
approved these changes
May 18, 2021
There was a problem hiding this comment.
Not sure what to make of all the DNS/email specifics but I trust you know what's up 😁
I think in terms of environment, production seems A-OK for now. In the future, maybe it makes sense to have a separate environment for all our peripheral infrastructure (dutyfree, boarding pass, etc.) and just leave production for ci.concourse-ci.org - but I could see an argument for keeping it all in production, too
aoldershaw
reviewed
May 18, 2021
| source = "../../dependencies/mailgun" | ||
|
|
||
| dns_zone = var.dns_zone | ||
| verification = "k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCiXNfw2u/anSOEvASvp94Rt+sp4ujO/AETVVtnqT3MC3By1EZBD8b0JowMZZKGkT9RwstC55fM66hhuJ0Az0lUZql2hex96k3mZjNUghaMoiPbIxa7bjYI2+vVEGIq5Y95PUJnKZMqEhe4WTob+vWGBsmKxHTr0lueShiO9fXFfwIDAQAB" |
There was a problem hiding this comment.
Just confirming this is meant to be public
There was a problem hiding this comment.
Yep - it's being set in a public DNS record for Mailgun to verify control of the domain, so it'll be public whether it's committed or not. We had the same question. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of concourse/governance#48 and friends