-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build only wide character library variants #76
base: main
Are you sure you want to change the base?
Build only wide character library variants #76
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This should be macOS only imho, on Linux it's normal to have non-wide and wide versions side by side. |
No, we have a heterogeneous landscape, see OP. For conda-forge it makes sense to look for homogeneity in its packages. That said, I expect this to be carefully reviewed (e.g., ensure all non-wide symbols are properly exported, etc.). |
2e2432c
to
d358f48
Compare
But still provide symlinks for <lib>w for backward compatibility. Signed-off-by: Marcel Bargull <[email protected]>
…nda-forge-pinning 2023.12.22.11.33.24 Signed-off-by: Marcel Bargull <[email protected]>
d358f48
to
9bbba42
Compare
Linux builds failed while linking the internal tests with ncurses.c:(.text.show_wbox_chars+0x92): undefined reference to `_nc_wacs' No idea why that symbol is missing... Signed-off-by: Marcel Bargull <[email protected]>
Linux builds didn't like to have
There are some more subtleties we'd want to iron out (e.g., only link main headers into top-level |
But still provide symlinks for w for backward compatibility.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)closes gh-21
NOTE: This is not yet tested and marked as draft to be merged (if acceptable) only after the holidays.
refs: