Upgrade Orkes queues to latest release #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Upgrade Orkes Queues dependency to v1.0.10. In this release
pop(String queueName, int count, int timeout)allows a zero timeout.Configuring that timeout in Conductor is possible with the property
conductor.app.system-task-queue-pop-timeout=0ms. This can help reduce latency.SEE: https://github.com/conductor-oss/conductor/pull/352/files#diff-851e41d4da224b55a13a38f01b092e04410663cb1b8f43f55d507b1a0fa65127
NOTES
SystemTaskWorkeralready polls every50msby default + we need to fix that timeout/long-poll behaviour in orkes-queues.