sync branch from main #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove previous index of event handlers by event if event handler's event gets updated * run ./gradlew spotlessApply
…(#3836) Issue Summary: There's a race condition in the system involving async system tasks and the WorkflowRepairService. For example, when a SUB_WORKFLOW task starts, the WorkflowRepairService sometimes erroneously reinserts the task into the processing queue because it perceives the task as out-of-sync between the ExecutorDAO and the queueDAO. This issue stems from the AsyncSystemTaskExecutor updating a task's status only after it removes it from the queue, creating a window where the WorkflowRepairService can wrongly assess the task state. This leads to duplicate subworkflows/http/… tasks being executed concurrently, which complicates maintaining idempotency of Tasks. Proposed Solution: To resolve the issue, it's suggested that the AsyncSystemTaskExecutor should update the status of tasks before removing them from the queue. This should close the window where the WorkflowRepairService can misidentify the task state and prevent unnecessary re-queuing of tasks. An edge case we’ve considered is if the process crashes after the task is updated but before it's removed from the queue. If that happens, the executor will simply remove the task from the queue the next time it runs, thereby not affecting system correctness. Co-authored-by: Jaim Silva <[email protected]>
* Version updates
* Fix: include monaco sources into bundle
* Optimizing reading from datastore during WorkflowSweeper#sweep * Added javadoc to decideWithLock method --------- Co-authored-by: Boyan Georgiev <[email protected]>
Fix Conductor users broken links
`provies` -> `provides`
…ername for ACL. (#3847) Co-authored-by: Anup Chatterjee <[email protected]>
Co-authored-by: Robert Karlsson <[email protected]>
* ISICO-15108: javascript validation done on updating w/d * ISICO-14902: NPE while checking EvaluatorType is fixed * ISICO-14902: unused variables removed * ISICO-15108: javascript validation added in the constraint violation part * ISICO-15108: getExpression() is used for switch javascript code
* Upgrading OSS libraries with known open CVEs * Updating the protobuf library. * Resolve the remaining build issues. --------- Co-authored-by: Scott Carter <[email protected]>
* Enable hosting app in any route, with easy config * Review Comments
OSS update
bugfix: wrong unit used in SetVariable error message
…traint Fix typo in WorkflowTaskTypeConstraint
Resolve open vulnerabilities in Conductor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered