Add guard against nullptr dereference in ConfigCatClient::close

configcat · Apr 2, 2024 · 34cc2e4 · 34cc2e4
1 parent c8f458d
commit 34cc2e4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/configcatclient.cpp b/src/configcatclient.cpp
@@ -67,6 +67,7 @@ std::shared_ptr<ConfigCatClient> ConfigCatClient::get(const std::string& sdkKey,
 }
 
 void ConfigCatClient::close(const std::shared_ptr<ConfigCatClient>& client) {
+    if (client)
     {
         lock_guard<mutex> lock(instancesMutex);
 
@@ -78,9 +79,10 @@ void ConfigCatClient::close(const std::shared_ptr<ConfigCatClient>& client) {
                 return;
             }
         }
+
+        LOG_ERROR_OBJECT(client->logger, 0) << "Client does not exist.";
     }
 
-    LOG_ERROR_OBJECT(client->logger, 0) << "Client does not exist.";
     assert(false);
 }