Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken code samples #348

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Fix broken code samples #348

merged 6 commits into from
Jan 11, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 10, 2024

Description

Fixes a few code samples that are not valid any more because of the changes to the JS SDK.

Trello card

n/a

Notes for QA

You may test that the changed code snippets work. (Just let me know if you need any help with that.)

Requirement checklist

  • I have validated my changes on a test/local environment.
  • I have checked the SNYK/Dependabot reports and applied the suggested changes.
  • (Optional) I have updated outdated packages.

@adams85 adams85 requested review from sigewuzhere and a team as code owners January 10, 2024 12:12
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 712dd51
Status: ✅  Deploy successful!
Preview URL: https://796e24b5.docs-xmy.pages.dev
Branch Preview URL: https://fix-code-samples.docs-xmy.pages.dev

View logs

sigewuzhere
sigewuzhere previously approved these changes Jan 10, 2024
website/docs/getting-started.md Outdated Show resolved Hide resolved
laliconfigcat
laliconfigcat previously approved these changes Jan 10, 2024
@adams85 adams85 merged commit 4148c0b into master Jan 11, 2024
3 checks passed
@adams85 adams85 deleted the fix-code-samples branch January 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants