Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REACT-SDK] add multiprovider support #494

Merged
merged 14 commits into from
Oct 16, 2024
Merged

[REACT-SDK] add multiprovider support #494

merged 14 commits into from
Oct 16, 2024

Conversation

endret
Copy link
Contributor

@endret endret commented Oct 3, 2024 •
edited
Loading

Description

Extend the react-sdk documentation with new feature: multiple provider support

Trello card

https://trello.com/c/hH7aPiws/349-react-sdk-multiple-configcatproviders-using-different-sdk-keys-in-react-sdk

Notes for QA

  • Ati is a good guy

Requirement checklist

  • I have validated my changes on a test/local environment.
  • I have tested that the code snippets I added work. (Leave unchecked if there are no new code snippets.)
  • I have added my changes to the V1 and V2 documentations.
  • I have checked the SNYK/Dependabot reports and applied the suggested changes.
  • (Optional) I have updated outdated packages.

@endret endret self-assigned this Oct 3, 2024
@endret endret requested a review from a team as a code owner October 3, 2024 23:07
@endret endret added the text-review The PR needs a review from the text reviewers team label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Head's up @configcat/text-reviewers - someone needs a text review!

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 3, 2024 •
edited
Loading

Deploying configcat-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a5a936
Status: ✅  Deploy successful!
Preview URL: https://b2f7550a.docs-xmy.pages.dev
Branch Preview URL: https://react-multiprovider-support.docs-xmy.pages.dev

View logs

@endret endret force-pushed the react-multiprovider-support branch from 2b94a1c to 2008b4c Compare October 4, 2024 08:11
zoltan-david
zoltan-david previously requested changes Oct 4, 2024
View reviewed changes
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/versioned_docs/version-V1/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/versioned_docs/version-V1/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/versioned_docs/version-V1/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/versioned_docs/version-V1/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/versioned_docs/version-V1/sdk-reference/react.mdx Outdated Show resolved Hide resolved
z4kn4fein
z4kn4fein previously approved these changes Oct 7, 2024
View reviewed changes
endret and others added 9 commits October 7, 2024 11:38
@endret @zoltan-david
Update website/docs/sdk-reference/react.mdx
c077a56 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/docs/sdk-reference/react.mdx
24be943 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/docs/sdk-reference/react.mdx
bf6f03b 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/versioned_docs/version-V1/sdk-reference/react.mdx
fa1dc34 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/versioned_docs/version-V1/sdk-reference/react.mdx
fb1319e 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/versioned_docs/version-V1/sdk-reference/react.mdx
a93a90a 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/versioned_docs/version-V1/sdk-reference/react.mdx
d91d3b0 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/versioned_docs/version-V1/sdk-reference/react.mdx
c1ecfc1 
Co-authored-by: Zoltan David <[email protected]>
@endret @zoltan-david
Update website/docs/sdk-reference/react.mdx
d659950 
Co-authored-by: Zoltan David <[email protected]>
z4kn4fein
z4kn4fein previously approved these changes Oct 9, 2024
View reviewed changes
@endret endret requested a review from zoltan-david October 9, 2024 19:43
z4kn4fein
z4kn4fein previously approved these changes Oct 10, 2024
View reviewed changes
adams85
adams85 requested changes Oct 10, 2024
View reviewed changes
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
website/docs/sdk-reference/react.mdx Outdated Show resolved Hide resolved
zoltan-david
zoltan-david reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@zoltan-david zoltan-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hagytam egy újabb commentet.
Vegyétek figyelembe ha gondoljátok.
De rátok bízom.
Mehet tovább nélkülem - én szabin vagyok, kérlek ne várjatok az approveomra.

@endret endret force-pushed the react-multiprovider-support branch from ebbf3b4 to 1d2587f Compare October 16, 2024 10:36
@endret endret dismissed zoltan-david’s stale review October 16, 2024 10:45

"Mehet tovább nélkülem - én szabin vagyok, kérlek ne várjatok az approveomra."

@endret endret requested review from adams85 and z4kn4fein October 16, 2024 10:46
adams85
adams85 requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@adams85 adams85 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all the changes to website/versioned_docs/version-V1/sdk-reference/react.mdx.

This is an archived documentation of a pre-Config V2 version of the React SDK:

image

We should not update this document with new features.

Apologies for pointing this out so late, I just realized this.

@endret
Copy link
Contributor Author

endret commented Oct 16, 2024

Please revert all the changes to website/versioned_docs/version-V1/sdk-reference/react.mdx.

This is an archived documentation of a pre-Config V2 version of the React SDK:

image

We should not update this document with new features.

Apologies for pointing this out so late, I just realized this.

was removed legacy changes

@endret endret requested a review from adams85 October 16, 2024 12:45
@adams85 adams85 added the text-approved When a text reviewer approves a PR label Oct 16, 2024
@endret endret merged commit 1dfa106 into master Oct 16, 2024
5 checks passed
@endret endret deleted the react-multiprovider-support branch October 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltan-david zoltan-david zoltan-david left review comments

@adams85 adams85 adams85 approved these changes

@z4kn4fein z4kn4fein Awaiting requested review from z4kn4fein

Assignees

@endret endret

Labels
text-approved When a text reviewer approves a PR text-review The PR needs a review from the text reviewers team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endret @z4kn4fein @adams85 @zoltan-david