Upgrade v4

[pasotee]

Describe the purpose of your pull request

• Upgrade Unreal Engine SDK to support the cpp-sdk [v4 release[(https://github.com/configcat/cpp-sdk/releases/tag/v4.0.0)

[kp-cat]

Thanks @pasotee for the PR.
Could you please fix the configcat dependency in the CI yml configs?

name: Plugin CD

on:
  workflow_dispatch:
  push:
    tags:
      - 'v*'

env:
  VCPKG_COMMIT_HASH: "59852bb5bd0779788e5fc95e50d2048ae6c9399d"

jobs:
  build-win64:
    runs-on: windows-latest

    steps:
      - uses: actions/checkout@v2

      - name: Install via vcpkg
        run: |
          git clone https://github.com/microsoft/vcpkg build/vcpkg
          git -C build/vcpkg checkout ${{ env.VCPKG_COMMIT_HASH }}
          ./build/vcpkg/bootstrap-vcpkg.bat
          ./build/vcpkg/vcpkg install configcat[core] --triplet x64-windows

      - uses: actions/upload-artifact@v3
        with:
          name: Win64
          path: |
            ./build/vcpkg/installed/*/lib/configcat.lib
            ./build/vcpkg/installed/*/lib/hash-library.lib

[kp-cat]

Could you please create an EnsureConfigCatClient() function where this log message can be printed:

bool EnsureConfigCatCline()
{
	if (ensure(ConfigCatClient))
	{
                return true;
        }
        
	UE_LOG(LogConfigCat, Warning, TEXT("Trying to access the ConfigCatClient before initialization or after shutdown."));
	return false;
}

In every function we can use this EnsureConfigCatClient() to check the client easier:

if (!EnsureConfigCatClient())
{
        return;
}

[pasotee]

That is a great idea. I added it now, thanks.

[kp-cat]

What is the standard? Is this line needed here?

[pasotee]

that is an oversight on my side. I have adjusted it with the proper copyright.

[kp-cat]

I think you can implement it like this:

Suggested change

	// UserCondition.comparisonValue;
	const auto comparisonValuePtr = get_if<string>(&UserCondition.comparisonValue);
	if (comparisonValuePtr)
	{
	return UTF8_TO_TCHAR(comparisonValuePtr->c_str());
	}

[pasotee]

Thanks for spotting those and for the suggestions, I didn't know they were a thing.

However, I have to implement the Has...Value functions as well, so I will be using that to check the values.

[kp-cat]

Suggested change

	// UserCondition.comparisonValue;
	const auto comparisonValuePtr = get_if<double>(&UserCondition.comparisonValue);
	if (comparisonValuePtr)
	{
	return *comparisonValuePtr;
	}

[pasotee]

Function is now implemented

[kp-cat]

Suggested change

	// UserCondition.comparisonValue;
	return {};
	TArray<FString> Result;
	const auto comparisonValuePtr = get_if<vector<string>>(&UserCondition.comparisonValue);
	if (comparisonValuePtr)
	{
	for (const auto& value : *comparisonValuePtr)
	{
	Result.Emplace(UTF8_TO_TCHAR(value.c_str()));
	}
	}
	return Result;

[pasotee]

Function is now implemented

[pasotee]

Thanks @pasotee for the PR. Could you please fix the configcat dependency in the CI yml configs?

name: Plugin CD

on:
  workflow_dispatch:
  push:
    tags:
      - 'v*'

env:
  VCPKG_COMMIT_HASH: "59852bb5bd0779788e5fc95e50d2048ae6c9399d"

jobs:
  build-win64:
    runs-on: windows-latest

    steps:
      - uses: actions/checkout@v2

      - name: Install via vcpkg
        run: |
          git clone https://github.com/microsoft/vcpkg build/vcpkg
          git -C build/vcpkg checkout ${{ env.VCPKG_COMMIT_HASH }}
          ./build/vcpkg/bootstrap-vcpkg.bat
          ./build/vcpkg/vcpkg install configcat[core] --triplet x64-windows

      - uses: actions/upload-artifact@v3
        with:
          name: Win64
          path: |
            ./build/vcpkg/installed/*/lib/configcat.lib
            ./build/vcpkg/installed/*/lib/hash-library.lib

This is awesome. I think it would benefit both the CI & CD pipelines, so I've added it to both