This repository has been archived by the owner on May 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
[protocol, card, client] Unrolled Deposit #462
Labels
Enhancement
New feature or request
p2: User Shipping Needs
Important (but minimal) refactors/enhancements/fixes needed for customers
Milestone
Comments
ArjunBhuptani
added
Enhancement
New feature or request
p2: User Shipping Needs
Important (but minimal) refactors/enhancements/fixes needed for customers
labels
Oct 20, 2019
ArjunBhuptani
changed the title
[protocol] Unrolled Deposit
[protocol, card] Unrolled Deposit
Oct 22, 2019
ArjunBhuptani
changed the title
[protocol, card] Unrolled Deposit
[protocol, card, client] Unrolled Deposit
Oct 22, 2019
This should also include the necessary changes to client/card to support the new deposit type. Doing so will fix a lot of the pesky bugs we're seeing with autodeposit int he card too |
Closed
ArjunBhuptani
added this to the Core wallet integration featureset completion milestone
Oct 22, 2019
Implementation details from Liam:
Indra implementation of these controllers:
|
For the edge case where there is a small window when async deposit can be wrongly credited to the hub, use the following workaround:
|
5 tasks
New updates to feature:
|
The primitive functions are already in the client so the use case can be supported at the app layer. Closing this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Enhancement
New feature or request
p2: User Shipping Needs
Important (but minimal) refactors/enhancements/fixes needed for customers
Separate out the deposit commitment from the onchain deposit transaction itself.
WIP: counterfactual/monorepo#2516
The text was updated successfully, but these errors were encountered: