Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI and go.mod versions #1133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/go-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to newline at the end of file. (you can see red circle mark)
https://gist.github.com/camh-/1bebfcff1b0f814e9b191edc60d5206b

4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version

- name: Build
env:
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version

- name: Build
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version
- uses: ibiqlik/action-yamllint@v3
with:
format: auto
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version
- name: Check module vendoring
run: |
go mod tidy
Expand All @@ -47,7 +47,7 @@ jobs:
- name: setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version
- name: Build on all supported architectures
run: |
set -e
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
- name: setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version
- name: Set up Go for root
run: |
sudo ln -sf `which go` `sudo which go` || true
Expand Down Expand Up @@ -106,6 +106,6 @@ jobs:
- name: setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
go-version-file: .github/go-version
- name: test
run: bash ./test_windows.sh
Loading