bridge: remove useless code #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur-zhang
changed the title
arthur-zhang
force-pushed
the
dev-pr-bridge
branch
from
b506bde to
820d0e7
Compare
|
help wanted, seems ci is broken. |
The issue you're complaining about was fixed in #967 Please rebase latest main branch, it should be OK then. |
maiqueb
approved these changes
Nov 2, 2023
maiqueb
approved these changes
Nov 2, 2023
|
/lgtm |
squeed
approved these changes
Nov 13, 2023
gws.defaultRouteFound here is always false. Signed-off-by: arthur-zhang <[email protected]>
Signed-off-by: arthur-zhang <[email protected]>
Signed-off-by: arthur-zhang <[email protected]>
squeed
force-pushed
the
dev-pr-bridge
branch
from
2323045 to
5280b4d
Compare
dcbw
reviewed
Nov 13, 2023
| @@ -240,7 +240,7 @@ func calcGateways(result *current.Result, n *NetConf) (*gwInfo, *gwInfo, error) | |||
|
|
|||
| // Add a default route for this family using the current | |||
| // gateway address if necessary. | |||
| if n.IsDefaultGW && !gws.defaultRouteFound { | |||
There was a problem hiding this comment.
Are we sure this is NOP? At this point gws refers to a global defined at the top of the function:
gwsV4 := &gwInfo{}
gwsV6 := &gwInfo{}
So if there are multiple v4/v6 addresses, I think defaultRouteFound would carry across the IP addressing loop. I think we need to keep this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gws.defaultRouteFound is always false.
firstV4Addr it is declared but not used anywhere in the code.