Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to mention Makefile variables #227

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 10, 2024

Also mention bootc-image-builder target.

@rhatdan
Copy link
Member Author

rhatdan commented Apr 10, 2024

This will need to be updated for all recipe readmes.

@rhatdan rhatdan force-pushed the man branch 5 times, most recently from 52450c6 to 0e4e348 Compare April 10, 2024 17:36
image. The following command will create an qcow2 image file from the default
bootc image in the build subdirectory.

`make bootc-image-builder DISK_TYPE=qcow2`
Copy link
Collaborator

@sallyom sallyom Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we added the target bootc-image-builder? 👀

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have 😃 🥇

@rhatdan rhatdan force-pushed the man branch 4 times, most recently from 0b7bcdf to 2408532 Compare April 10, 2024 17:49
@rhatdan
Copy link
Member Author

rhatdan commented Apr 10, 2024

@MichaelClifford @sallyom @lmilbaum @Gregory-Pereira PTAL

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, very nice touch with the recipes/common/README.md file

Also mention bootc-image-builder target.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan merged commit b86c80f into containers:main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants