Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable tests for sample apps #247

Merged
merged 2 commits into from
Apr 12, 2024
Merged

enable tests for sample apps #247

merged 2 commits into from
Apr 12, 2024

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Apr 11, 2024 •
edited
Loading

  • adds functional_tests for codegen, rag, summarizer
  • adds image build for ^^ and llamacpp-cuda model-server
  • adds placeholder for cuda functional_tests

partially resolves #204

@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2024

We have to make sure people pay attention to this. BTW I broke make bootc

@sallyom sallyom force-pushed the tests branch 3 times, most recently from 5b5d059 to d0eda22 Compare April 11, 2024 19:58
@sallyom sallyom changed the title wow this is a huge PR to set up testing for all apps huge PR to set up testing for all apps Apr 11, 2024
@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2024

@lmilbaum PTAL

@sallyom sallyom force-pushed the tests branch 2 times, most recently from f170bc7 to 3a755bb Compare April 11, 2024 21:08
@sallyom sallyom mentioned this pull request Apr 11, 2024
Merged
@sallyom sallyom force-pushed the tests branch 5 times, most recently from 9f93d55 to 932f4df Compare April 12, 2024 00:58
@sallyom sallyom changed the title huge PR to set up testing for all apps enable tests for sample apps Apr 12, 2024
@sallyom
fix
6fbfd23 
Signed-off-by: sallyom <[email protected]>
This was referenced Apr 12, 2024
Closed
Closed
@rhatdan
Copy link
Member

rhatdan commented Apr 12, 2024

LGTM

@rhatdan rhatdan merged commit 3734eae into containers:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend CI for all sample applications with every PR
2 participants
@sallyom @rhatdan