Run HealthCheck without saving the ExecSession to the database
#25003
+97
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Honny1
force-pushed
the
no-db-healtcheck-exec
branch
from
ac4e5b3 to
31172f4
Compare
Honny1
changed the title
ExecSession to the database
Honny1
force-pushed
the
no-db-healtcheck-exec
branch
from
31172f4 to
79dddb6
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Honny1
added
the
No New Tests
…database Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
no-db-healtcheck-exec
branch
from
79dddb6 to
a2e6f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a method to run the HealthCheck command without creating and deleting an
ExecSessionin the database.When HealthCheck is run using the original
execmethod, anExecSessionis created and deleted. This approach causes unexpectedly higher IO usage when synchronizing the container and creating and deletingExecSessionin the database.The new
healthCheckExecfunction locks the container and creates theExecSessionlocally without writing to the database. Executes a localExecSession. As a result, the number of writes in the database has been reduced to zero.Verify reduction
TBD
Does this PR introduce a user-facing change?