Skip to content

Commit

Permalink
Merge pull request #28 from rhatdan/unshare
Browse files Browse the repository at this point in the history 
use unshare rather then chroot to enable hirte-agent.service
  • Loading branch information
@rhatdan
rhatdan authored May 5, 2023
2 parents 981164c + 8a6f03e commit a56748f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ hirteSetup() {
NodeName=qm.${hostname}
EOF
fi
chroot ${rootfs} systemctl enable hirte-agent 2> /dev/null
unshare --mount-proc -R /usr/lib/qm/rootfs -m systemctl enable hirte-agent.service
}

install() {
Expand Down

3 comments on commit a56748f

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your Packit configuration the settings of the rhcontainerbot/qm Copr project would need to be updated as follows:

field old value new value
chroots ['fedora-38-aarch64', 'fedora-38-ppc64le', 'fedora-38-x86_64', 'centos-stream-9-aarch64', 'centos-stream-9-ppc64le', 'centos-stream-9-x86_64'] ['centos-stream-9-aarch64', 'centos-stream-9-ppc64le', 'centos-stream-9-s390x', 'centos-stream-9-x86_64', 'fedora-38-aarch64', 'fedora-38-ppc64le', 'fedora-38-x86_64']

Diff of chroots:

+centos-stream-9-s390x

Packit was unable to update the settings above as it is missing admin permissions on the rhcontainerbot/qm Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the rhcontainerbot/qm Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your Packit configuration the settings of the rhcontainerbot/qm Copr project would need to be updated as follows:

field old value new value
chroots ['fedora-38-aarch64', 'centos-stream-9-x86_64', 'fedora-38-ppc64le', 'centos-stream-9-aarch64', 'fedora-38-x86_64', 'centos-stream-9-ppc64le'] ['centos-stream-9-aarch64', 'centos-stream-9-ppc64le', 'centos-stream-9-s390x', 'centos-stream-9-x86_64', 'fedora-38-aarch64', 'fedora-38-ppc64le', 'fedora-38-x86_64']

Diff of chroots:

+centos-stream-9-s390x

Packit was unable to update the settings above as it is missing admin permissions on the rhcontainerbot/qm Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the rhcontainerbot/qm Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your Packit configuration the settings of the rhcontainerbot/qm Copr project would need to be updated as follows:

field old value new value
chroots ['fedora-38-aarch64', 'fedora-38-ppc64le', 'fedora-38-x86_64', 'centos-stream-9-aarch64', 'centos-stream-9-ppc64le', 'centos-stream-9-x86_64'] ['centos-stream-9-aarch64', 'centos-stream-9-ppc64le', 'centos-stream-9-s390x', 'centos-stream-9-x86_64', 'fedora-38-aarch64', 'fedora-38-ppc64le', 'fedora-38-x86_64']

Diff of chroots:

+centos-stream-9-s390x

Packit was unable to update the settings above as it is missing admin permissions on the rhcontainerbot/qm Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the rhcontainerbot/qm Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Please sign in to comment.