Set up integration tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbadoman
reviewed
Nov 20, 2023
tests/integration/corbado_test.go
Outdated
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func initClient(t *testing.T) corbado.SDK { |
There was a problem hiding this comment.
how about we name it sdk() and daisy chain it in the actual tests?
corbadoman
reviewed
Nov 20, 2023
| @@ -0,0 +1,28 @@ | |||
| //go:build integration | |||
|
|
|||
| package integration_test | |||
There was a problem hiding this comment.
subdirectories per group/tag?
corbadoman
reviewed
Nov 20, 2023
| }) | ||
|
|
||
| require.NoError(t, err) | ||
| assert.NotEmpty(t, rsp.Data.EmailLinkID) |
There was a problem hiding this comment.
should discuss this in whatsapp: do we want to assert on every field (lots of work but will catch the most bugs) or do we skips this and make the asserts easy aka "no error and 'some' data". maybe check the others, i think stripe is doing the first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.