Add experimental promQL funcs #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Nov 5, 2024
opts.go
Outdated
| enableOffset bool | ||
| enableAtModifier bool | ||
| enableVectorMatching bool | ||
| enableExperimentalPromQL bool |
There was a problem hiding this comment.
Can we call it enableExperimentalPromQLFunctions? Same as https://prometheus.io/docs/prometheus/latest/feature_flags/#experimental-promql-functions.
It is not just functions but I think it is more accurate to mention that
walk.go
Outdated
| @@ -83,6 +83,10 @@ func (s *PromQLSmith) walkAggregateParam(op parser.ItemType) parser.Expr { | |||
| return s.Walk(parser.ValueTypeScalar) | |||
| case parser.COUNT_VALUES: | |||
| return &parser.StringLiteral{Val: "value"} | |||
| case parser.LIMITK, parser.LIMIT_RATIO: | |||
| if s.enableExperimentalPromQL { | |||
There was a problem hiding this comment.
So we pick an aggregation type randomly from enabled aggregate operators. But for now I think default aggregate operators don't include limitk and limit_ratio.
There was a problem hiding this comment.
This might go wrong if users enable the feature flag but don't add the operators to enabled aggregate operators
| expr.Args = append(expr.Args, &parser.StringLiteral{Val: name}) | ||
| cnt++ | ||
| } | ||
| } |
There was a problem hiding this comment.
There are 2 issues here:
- there is no randomization since
s.labelNamesare always the same order - For refernece you can check
walkLabelJoin. We try to get the underlying vector selector and infer what labels it might have and pick labels there. This increases the chance where the labels used in the query actually makes sense for the series
Signed-off-by: kade.lee <[email protected]>
SungJin1212
force-pushed
the
Support-experimental-promQLs
branch
from
782da6a to
228f5f4
Compare
|
@yeya24
|
yeya24
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental promQL funcs.