original timeoutTimestamp value in forwarding #1163
Conversation
| @@ -456,7 +459,7 @@ function onRecvPacket( | |||
|
|
|||
| packetSequence=handler.sendPacket( | |||
| forwarding.hops[0].channelId, | |||
| currentTime() + DefaultHopTimeoutPeriod, | |||
| originalTimeoutTimestamp, | |||
| forwardingPayload | |||
| ) | |||
| // store previous packet sequence and destChannelId for future sending ack | |||
There was a problem hiding this comment.
One open question is: when we to store the forwarded packet info, is the payload.destPort really necessary?
I added it thinking that the payload.destPort may be slightly different for different ecosystems. @chatton make me notice it may be always equal instead.
If that's the case then we can just reuse the payload.destPort in the
function revertInFlightChanges( sentPacketDestChannelId: bytes, sentPacketPayload: Payload, receivedPacketDestChannelId: bytes, receivedPacketDestPort: bytes,
and thus reduce its input parameter by deleting the receivedPacketDestPort.
What's your opinion here @AdityaSripal ?
There was a problem hiding this comment.
They can be different across ecosystems. In fact there are already transfer modules in cosmos that do not use the transfer port :)
Thus it is correct as it is.
This PR is a spec adjustment following the discussion with @chatton and @AdityaSripal regarding the usage of the original packet timeout instead of
currentTimet() + DefaultHopTimeoutPeriodin the forwarded packet.