-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for xuetangx.com #412
base: master
Are you sure you want to change the base?
Conversation
Changes Unknown when pulling 6ff43be on mcfloundinho:master into ** on coursera-dl:master**. |
2 similar comments
Changes Unknown when pulling 6ff43be on mcfloundinho:master into ** on coursera-dl:master**. |
Changes Unknown when pulling 6ff43be on mcfloundinho:master into ** on coursera-dl:master**. |
Changes Unknown when pulling 8c47c43 on mcfloundinho:master into ** on coursera-dl:master**. |
Changes Unknown when pulling b8c2684 on mcfloundinho:master into ** on coursera-dl:master**. |
Hello, thanks, awesome job, Thanks a lot for contributing, and sorry if I took some time to review your changes. |
One extra question have you tried your code on windows? We use to have tons of problems with chinese characters in windows, that's the reason why we ultra simplified everything to be ASCII. Anyway I think this solution is not future proof and maybe we must fix it as part of your PR (or I will do it in a future one). |
@iemejia Hello! I'm very pleased to improve my code or, if possible, help with the further maintenance of the project. I'll try coping with the windows encoding issue maybe later this week. |
Awesome, this is great news, don't hesitate to ping me if you need anything. More hands that can help us improve the project are always welcome. |
Changes Unknown when pulling 7ab5045 on mcfloundinho:master into ** on coursera-dl:master**. |
1 similar comment
Changes Unknown when pulling 7ab5045 on mcfloundinho:master into ** on coursera-dl:master**. |
Thanks, sorry I have not had many free time recently but I will try to check it ASAP, I will keep you posted, again sorry for the delay. |
@mcfloundinho, can you please check which changes are needed now that edX has changed their structure? Do your proposed changes still work? Please, take a look at my changes in b6c77a6 in particular. |
@mcfloundinho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase your changes to the current master branch?
Xuetangx, based on OpenEdX, is the most popular MOOC platform in China. It would be fine to support it :-)
add support for xuetangx.com.
Xuetangx has some malformed HTMLs, like this: <a href=&coursera-dl#34; /c4x/TsinghuaX/70250023X/asset/LST0-1-0___________.zip&coursera-dl#34;>一个有趣应用-动画文件</a></pre><p></p></o1> in http://www.xuetangx.com/courses/course-v1:TsinghuaX+70250023X_2015_2+sp/courseware/bfbdec0177a7466d9b6bc48c011ee401/63a0945fa22d486fa4e6976802f1f037/ from which the extracted url is 'http://www.xuetangx.com /c4x/TsinghuaX/70250023X/asset/LST0-1-0___________.zip', and it's necessary to remove the space.
building file names
@rbrito Yes, I've done the rebase. Sorry for the delay. |
🚨Please review the guidelines for contributing to this repository.
Proposed changes
Xuetangx (http://www.xuetangx.com/), based on OpenEdX, is the most popular MOOC platform in China. It would be fine to support it :-)
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.
Reviewers
If you know the person who can review your code please add a @mention.