-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hook-store): Add uni-v2 deposit hook dapp #5245
base: develop
Are you sure you want to change the base?
feat(hook-store): Add uni-v2 deposit hook dapp #5245
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@yvesfracari is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yvesfracari , thank you, great job!
Some questions related to the simulation:
- On Ethereum, it returns 500 error. In this case I use not 100%, but a partial balance of a token's swap:
- Report
- calldata: :
0xa8481abe00000000000000000000000000000000000000000000000000000000000000a0313733363433313734323831380000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000677fe68f0000000000000000000000009fa3c00a92ec5f96b1ad2527ab41b3932efeda580000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000000500000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000001e00000000000000000000000000000000000000000000000000000000000000320000000000000000000000000000000000000000000000000000000000000044000000000000000000000000000000000000000000000000000000000000005600000000000000000000000005afe3855358e112b5647b952709e6165e1c1eeee000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006423b872dd0000000000000000000000009fa3c00a92ec5f96b1ad2527ab41b3932efeda5800000000000000000000000079932c178ad3d0a4864b0322ce7a8405d74de2900000000000000000000000000000000000000000000000000944f7025aa2bfd300000000000000000000000000000000000000000000000000000000000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006423b872dd0000000000000000000000009fa3c00a92ec5f96b1ad2527ab41b3932efeda5800000000000000000000000079932c178ad3d0a4864b0322ce7a8405d74de2900000000000000000000000000000000000000000000000000000ae7d908f7b49000000000000000000000000000000000000000000000000000000000000000000000000000000005afe3855358e112b5647b952709e6165e1c1eeee000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b30000000000000000000000007a250d5630b4cf539739df2c5dacb4c659f2488dffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff00000000000000000000000000000000000000000000000000000000000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b30000000000000000000000007a250d5630b4cf539739df2c5dacb4c659f2488dffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff000000000000000000000000000000000000000000000000000000000000000000000000000000007a250d5630b4cf539739df2c5dacb4c659f2488d000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000104e8e337000000000000000000000000005afe3855358e112b5647b952709e6165e1c1eeee000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc20000000000000000000000000000000000000000000000000944f7025aa2bfd30000000000000000000000000000000000000000000000000000ae7d908f7b490000000000000000000000000000000000000000000000000940380d19f145950000000000000000000000000000000000000000000000000000ae2439be4c720000000000000000000000009fa3c00a92ec5f96b1ad2527ab41b3932efeda5800000000000000000000000000000000000000000000000000000000677fe687000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000041eb16e750ab5e9894d458433da976bee611d716d6adba5337143464db50290a9a18d5cf8d0693ced4f3c9655a3558cdf1a2a502c18cf1dbc8c25ee2de618168671c000000000000000000000000000000000000000000000000000000000000002e7e978da0c53404a8cf66ed4ba2c7706c07b62a5afe3855358e112b5647b952709e6165e1c1eeeec02aaa39b223fe8d0a0e5c4f27ead9083c756cc20000000000000000000000000000000000000000000000000944f7025aa2bfd30000000000000000000000000000000000000000000000000000ae7d908f7b495aFE3855358E112B5647B952709E6165e1c1eEEe00
target:
0x00E989b87700514118Fa55326CD1cCE82faebEF6
gasLimit:
840000
-
Hook name shows 'unknown' on the Confirm and Account modals (when an order is placed)
-
I faced this on Base and Arb networks: when I added a hook for the 1st time, there was not simulaiton report displayed, Console shows 502 error. Retriggering a hook's simulation helped to resolve this issue
On the confirm modal when a simulation runs on its opening, console shows 503 errors for simulation reports:
Could you please check why this is happening?
Summary
Add Uniswap V2 Deposit Hook Dapp
To Test
1- Connect your wallet and switch to any Uni v2 deployed chain (Arbitrum, Mainnet, Sepolia and Base)
2- In Hooks > Add Post-Hook Action, the Uni V2 Deposit should appear in the "All hooks" section
3- Fill the form data and add the post-hook
4- Check with the simulation feature to see if it is working as expected.
Notes: