[CoW AMM] Metric for daily invariant growth (surplus) per $100 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
changed the title
fleupold
changed the title
fhenneke
reviewed
Sep 10, 2024
| ), | ||
|
|
||
| -- Computes the token balance changes of the relevant token per transaction | ||
| reserves_delta as ( |
There was a problem hiding this comment.
Most of the query can be substitutes by calling the base query.
The base query also tries to take care of
- liquidity injections
- deposits and withdrawals
If it is actually this easy, the simplifications should be added to the base query as well.
There was a problem hiding this comment.
Which base query do you mean exactly? I created #27 (but am not aware of an existing one)
There was a problem hiding this comment.
I meant query 3968186, which is currently used for dashboards. It is not currently part of this repo.
Merged
fleupold
force-pushed
the
cowamm/surplus_growth_cow
branch
from
65e465b to
5c0690a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an additional metric next to "growth of 10k" we want to compare the invariance growth of CoW AMMs with the ones from Uniswap.
For CoW AMM this is equal to surplus, for Uniswap it's equal to the swap fee amount (volume * 0,3%). Both are normalized over TVL in order to have a reasonable comparison.
This query adds the comparison for CoW AMM.
Test Plan
Comparing https://balancer.fi/pools/ethereum/cow/0xf08d4dea369c456d26a3168ff0024b904f2d8b91 with https://dune.com/queries/4059213 for a rough sanity check (values cannot match exactly because balancer uses a different price feed)