Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend service fee query to all chains #84

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Dec 5, 2024

This PR adds the service fee query and the reduced bonding pools query to work for all chains

@fleupold fleupold added the E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details label Dec 6, 2024
harisang added a commit to cowprotocol/solver-rewards that referenced this pull request Dec 6, 2024
This PR add the blockchain parameter to the service fee query.

The query was adapted to accept this parameter in
cowprotocol/dune-queries#84

Co-authored-by: Haris Angelidakis <[email protected]>
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks reasonable.

I still think that hard-coding all start dates would be a better solution.

@harisang harisang merged commit da1e3fb into main Dec 6, 2024
2 checks passed
@harisang harisang deleted the extend_service_fee_query_to_all_chains branch December 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants