This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Add optional env variables to bypass runtime arguments #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing the PR since this change is no longer needed. |
harisang
deleted the
add_optional_env_variables_to_bypass_runtime_arguments
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two environment variables, named
argandtable, that are only meant to be used from within the Prefect infrastructure to set up relevant jobs.An obvious problem is that this leaks implementation details and/or restrictions of Prefect into this repo.
Could an alternative be to actually pass parameters to the main function? Not sure if that is very bad practice or not.