This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Comment out warehouse related parts #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
I do not really know how to check this code. It looks fine, I guess.
In general I would say that commenting out code is less maintainable than removing code. We can always revert this PR if necessary.
If we remove internal imbalances, we should also have a look at the code in solver-rewards and on tenderly.
Closing the issue in favor of PR #87 to address reviewer's comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes/comments out warehouse db references.
We decided to not fully remove those as we might need to revert and restart the internalization simulations.
Addresses issue #84