fix: fix decimals and update lists #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
commented
Dec 17, 2024
| @@ -791,17 +799,9 @@ | |||
| "address": "0x18dd5b087bca9920562aff7a0199b96b9230438b", | |||
| "name": "Propy", | |||
| "symbol": "PRO", | |||
| "decimals": 18, | |||
| "decimals": 8, | |||
shoom3301
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the decimals for
PROtoken with address0x18dD5B087bCA9920562aFf7A0199b96B9230438bin Base chain.It had 18 decimals, but the contract has 8. See https://basescan.org/token/0x18dD5B087bCA9920562aFf7A0199b96B9230438b
I re-generated the lists too. I will point in the code the most relevant change. The rest is the update of the most trade token lists.
Why it was wrong? I'm not sure, but I think its because the token had the wrong decimals in the Coingecko list we use to load the tokens
https://tokens.coingecko.com/uniswap/all.json