Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmoj problem labels? #4066

Merged
merged 7 commits into from
Dec 6, 2023
Merged

dmoj problem labels? #4066

merged 7 commits into from
Dec 6, 2023

Conversation

SansPapyrus683
Copy link
Contributor

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

tries to close #3756, probably fails tho

Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add these diff sources under problems.ts, so that we have the dropdown + message when edi doesn't exist.

image

@SansPapyrus683
Copy link
Contributor Author

SansPapyrus683 commented Dec 4, 2023

uh the editorial sources are still listed under dmoj so

image

shouldn't it read from here

@ryanchou-dev
Copy link
Member

uh the editorial sources are still listed under dmoj so

image

shouldn't it read from here

nah like on the problem table, the source name dont have the hover thing

likely fine, but just to be consistent

@SansPapyrus683
Copy link
Contributor Author

ok just wait a lil

@SansPapyrus683
Copy link
Contributor Author

image

ok i added dmopc, which like 80% of the problems come from

@ryanchou-dev
Copy link
Member

ok sounds good... maybe someone from web dev could approve

@SansPapyrus683 SansPapyrus683 merged commit 497042c into cpinitiative:master Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMOJ Contests have Inconsistent Labels
2 participants