Improve handling of events that aren't pull requests #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's recommended that the workflow be set to run if a push OR pull_request is made. However, if a push was made to the main branch and there were any new packages that were archived on CRAN, these wouldn't be caught because the script checks against the version on the main branch (so there would never be a diff of archived packages). Now, if the event that triggered the workflow is not a pull request, the workflow fails if there are ANY archived packages, regardless of what the version on main looks like. This also now makes it work for scheduled jobs, so I've added the recommendation that the workflow be scheduled to run once a month.