Merge pull request #8 from jtraglia/a-better-int

Remove to_string from Scalar::__int__ method
crate-crypto · Aug 30, 2024 · 02e1049 · 02e1049
2 parents 0a0f979 + 4872051
commit 02e1049
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/examples/scalar.py b/examples/scalar.py
@@ -41,4 +41,5 @@
 assert scalar == deserialised_scalar
 
 # Conversion to int
+assert int(Scalar(0)) == 0
 assert int(Scalar(12345)) == 12345
diff --git a/src/wrapper.rs b/src/wrapper.rs
@@ -229,8 +229,7 @@ impl Scalar {
         }
     }
     fn __int__(&self) -> BigUint {
-        // Bug, Fr::to_string will print nothing if the value is zero
-        BigUint::from_str(&*self.0.to_string()).unwrap_or(BigUint::ZERO)
+        BigUint::from(self.0.into_bigint())
     }
 
     fn pow(&self, exp: Scalar) -> Scalar {