Merge pull request #10 from jtraglia/subclass

Change `#[pyclass]` to `#[pyclass(subclass)]` for structs
crate-crypto · Sep 24, 2024 · 96d8516 · 96d8516
2 parents c0cb3e6 + 5120382
commit 96d8516
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/examples/scalar.py b/examples/scalar.py
@@ -42,4 +42,10 @@
 
 # Conversion to int
 assert int(Scalar(0)) == 0
-assert int(Scalar(12345)) == 12345
+assert int(Scalar(12345)) == 12345
+
+# The ability to inherit Scalar
+class NewScalar(Scalar):
+    pass
+
+assert NewScalar(1) == Scalar(1)
diff --git a/src/wrapper.rs b/src/wrapper.rs
@@ -14,7 +14,7 @@ const G2_COMPRESSED_SIZE: usize = 96;
 const SCALAR_SIZE: usize = 32;
 
 #[derive(Copy, Clone)]
-#[pyclass]
+#[pyclass(subclass)]
 pub struct G1Point(G1Projective);
 
 #[pymethods]
@@ -99,7 +99,7 @@ impl G1Point {
 }
 
 #[derive(Copy, Clone)]
-#[pyclass]
+#[pyclass(subclass)]
 pub struct G2Point(G2Projective);
 
 #[pymethods]
@@ -184,7 +184,7 @@ impl G2Point {
 }
 
 #[derive(Copy, Clone)]
-#[pyclass]
+#[pyclass(subclass)]
 pub struct Scalar(ark_bls12_381::Fr);
 
 #[pymethods]
@@ -264,7 +264,7 @@ impl Scalar {
 }
 
 #[derive(Copy, Clone)]
-#[pyclass]
+#[pyclass(subclass)]
 pub struct GT(ark_bls12_381::Fq12);
 
 #[pymethods]