SEARCH-8101 Cancel the query upon timeout #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsalvinho
approved these changes
Dec 10, 2024
dcheckoway
force-pushed
the
dc/SEARCH-8103-grafana-plugin-include-info-about-scheduled-queries-in-the-timeout-error
branch
from
7f25a8a to
98c9c07
Compare
Base automatically changed from
dc/SEARCH-8103-grafana-plugin-include-info-about-scheduled-queries-in-the-timeout-error
to
dc/v1.1.2
December 10, 2024 20:35
dcheckoway
force-pushed
the
dc/SEARCH-8101-grafana-plugin-cancel-query-upon-timeout
branch
from
4ef78d0 to
1ecea93
Compare
dcheckoway
deleted the
dc/SEARCH-8101-grafana-plugin-cancel-query-upon-timeout
branch
dcheckoway
added a commit
that referenced
this pull request
Dec 12, 2024
* go get -u github.com/grafana/grafana-plugin-sdk-go * npx -y @grafana/create-plugin@latest update * SEARCH-8100 Make query timeout configurable (#29) * SEARCH-8103 Include info about scheduled queries in the timeout error (#30) * SEARCH-8309 Allow savedSearchId to be composed using variable(s) (#27) * SEARCH-8309 Allow savedSearchId to be composed using variable(s) * SEARCH-8309 Update QueryEditor to allow typing savedSearchId with ${variable} * SEARCH-8101 Cancel the query upon timeout (#31) * ran "npx -y @grafana/create-plugin@latest update" again * Bumps for v1.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the query takes longer than the configured timeout, at least try to cancel the search job on the Cribl side.
To test this, you can set the timeout to a relatively low value like 5 or 10 seconds, then run a query like
On the Cribl side, you can find the job by its id and confirm that it was indeed canceled.