update composition environment docs to function-environment-configs #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phisco
force-pushed
the
bye-bye-composition-environment
branch
3 times, most recently
from
4c6a437 to
25c0a00
Compare
|
Vale 😩🥸🤡🫠 |
|
ahh, putting aside vale issues, it looks like the build itself is failing. I'll take a pass through this PR to try to get everything ready 👍 |
Signed-off-by: Philippe Scorsolini <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
jbw976
force-pushed
the
bye-bye-composition-environment
branch
from
25c0a00 to
ff712f0
Compare
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
|
Take this PR out of draft status now that all Vale errors and HTML link errors are fixed. Note the Vale check is still failing, but only with Warnings (0 Errors), which is acceptable. I'll focus on reviewing the content now. |
Signed-off-by: Jared Watts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs to include information about how to use
EnvironmentConfigswithfunction-environment-configs. This will help Crossplane users migrate theirCompositionsdue to the impact of maturingEnvironmentConfigto Beta while removing native composition support for them in crossplane/crossplane#5938.