Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[idl-generator] Add support for Dictionary #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[idl-generator] Add support for Dictionary #26

wants to merge 1 commit into from

Conversation

d0ngjun
Copy link

@d0ngjun d0ngjun commented Nov 10, 2014

  1. add support for dictionary.
  2. add support for multiple idl files(one definition per file).
  3. add code in idl_demo for demonstrating how to use dictionary.

Unverified

This user has not yet uploaded their public signing key.
1) add support for dictionary.
2) add support for multiple idl files(one definition per file).
3) add code in idl_demo for demonstrating how to use dictionary.
@d0ngjun d0ngjun closed this Nov 10, 2014
@d0ngjun d0ngjun reopened this Nov 10, 2014
@d0ngjun
Copy link
Author

d0ngjun commented Nov 10, 2014

@deqing @halton @zliang7 , Please help review, thanks!

# if not target.is_partial and target.name != idl_file_basename:
# raise Exception(
# 'Definition name "{0}" disagrees with IDL file basename "{1}".'
# .format(target.name, idl_file_basename))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using multiple idls now. Do u still need to comment out this code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants