Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/create api #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/create api #2

wants to merge 3 commits into from

Conversation

kulabuha
Copy link
Contributor

@kulabuha kulabuha commented Jan 7, 2024

No description provided.

svok
svok requested changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@svok svok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Алексей, отличная работа.
Обратите внимание на комментарии.
Работу я приму, но прошу учесть комментарии в этом же ПР.
Когда поправите, мне лично сообщите, я волью ПР в main.

.gitignore
!**/src/main/**/build/
!**/src/test/**/build/

### IntelliJ IDEA ###
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Прошу мусор убрать из проекта

specs/resource_bookings-v1.yaml
components:
schemas:

IRequest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В crowdproj есть базовая спека, ее необходимо подцепить. Она обеспечивает связь между проектами. в crowdproj-ad есть пример как это сделать.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svok svok svok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulabuha @svok