Fix: Allow ACM lookups beyond 100 certs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ellation` account now has 147 certificates in it, so this is no longer sufficient. Relates to fixing REDA-632
ryansb
force-pushed
the
fix/acm-beyond-100-certs
branch
from
87cedf9 to
23cbbac
Compare
mattbarlow-sg
approved these changes
Aug 27, 2024
cbeauroll
approved these changes
Aug 27, 2024
curtisharm
approved these changes
Aug 27, 2024
Comment on lines
+88
to
+99
| next_token = None | ||
| while True: | ||
| response = acm_client.list_certificates( | ||
| CertificateStatuses=['ISSUED'], | ||
| MaxItems=100, | ||
| NextToken=next_token | ||
| ) | ||
| cert_summaries.extend(response["CertificateSummaryList"]) | ||
| if response.get("NextToken"): | ||
| next_token = response["NextToken"] | ||
| else: | ||
| break |
There was a problem hiding this comment.
Suggested change
| next_token = None | |
| while True: | |
| response = acm_client.list_certificates( | |
| CertificateStatuses=['ISSUED'], | |
| MaxItems=100, | |
| NextToken=next_token | |
| ) | |
| cert_summaries.extend(response["CertificateSummaryList"]) | |
| if response.get("NextToken"): | |
| next_token = response["NextToken"] | |
| else: | |
| break | |
| response = | |
| acm_client.get_paginator('list_certificates').paginate(CertificateStatuses=['ISSUED']).build_full_result() |
Boto3 has some cool built in paginator stuff, while loop works tho
There was a problem hiding this comment.
The version ef-open uses doesn't seem to have ACM paginators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
REDA-632
Description
The
ellationaccount now has 147 certificates in it, so this is no longer sufficient.Can this PR be merged / deployed at any time?
Timeframe/Conditions:
How was this tested?