Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pvc): split PVCs for database and storage #1010

Open
wants to merge 4 commits into
base: split-deployment
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #1004

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@andrewazores andrewazores added feat New feature or request safe-to-test labels Jan 14, 2025
@andrewazores
Copy link
Member Author

/build_test

@andrewazores
Copy link
Member Author

Copy link

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member Author

/build_test

@andrewazores
Copy link
Member Author

Copy link

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member Author

	Name: olm-spec-descriptors
	State: fail

	Suggestions:
		Add a spec descriptor for storageOptions
	Errors:
		storageOptions does not have a spec descriptor

 	Name: olm-crds-have-validation
	State: fail

	Suggestions:
		Add CRD validation for spec field `storageOptions` in Cryostat/v1beta2

@ebaron is this because I renamed the CRD property in v1beta2 compared to what v1beta1 had? storageOptions no longer appears in v1beta2 so I'm not really sure what I'm seeing here.

@ebaron
Copy link
Member

ebaron commented Jan 16, 2025

I'm not sure if this is causing the test failure, but I don't think we can break API by renaming an existing property in v1beta2:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md

I think the proper way would be to deprecate the old property, but still use it as a fallback if the new properties aren't given.
Something like this in terms of precedence:

  1. Database:
    i. spec.storageConfig.Database
    ii. spec.storageOptions
    iii. Operator defaults
  2. Object Storage:
    i. spec.storageConfig.ObjectStorage
    ii. spec.storageOptions
    iii. Operator defaults

@andrewazores
Copy link
Member Author

/build_test

Copy link

/build_test : At least one test failed ❌.
View Actions Run.

Copy link

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores marked this pull request as ready for review January 17, 2025 16:04
@andrewazores andrewazores requested a review from ebaron January 17, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants