chore(recordings): check target's jvmId for recording events #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on:
|
mwangggg
changed the title
7 tasks
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
2 times, most recently
from
ade8102 to
d36c54d
Compare
7 tasks
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
from
4679516 to
bef3a97
Compare
tthvo
reviewed
Oct 3, 2023
tthvo
reviewed
Oct 3, 2023
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
from
422bc0d to
e9075d9
Compare
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
3 times, most recently
from
d3c2b83 to
c6c55b5
Compare
|
had to re-add the connectUrl check in notification messages because the integration tests were failing without them |
|
/build_test |
|
Test image available: |
|
/build_test |
|
Test image available: |
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
3 times, most recently
from
68e9eb4 to
d36b002
Compare
mwangggg
force-pushed
the
1452-target-include-jvmID-web
branch
from
d36b002 to
6d7bdc8
Compare
andrewazores
approved these changes
Oct 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit c75c36a)
andrewazores
pushed a commit
that referenced
this pull request
Oct 31, 2023
…1151) (cherry picked from commit c75c36a) Co-authored-by: Ming Yu Wang <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainDepends on https://github.com/cryostatio/cryostat/pull/1689
Related to https://github.com/cryostatio/cryostat/issues/1452