-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(version): copy guides to 2.2.0 version and create new latest/2.3.0 version #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
feat
New feature or request
docs
Improvements or additions to documentation
labels
Apr 26, 2023
tthvo
reviewed
Apr 28, 2023
andrewazores
force-pushed
the
version-230
branch
2 times, most recently
from
May 5, 2023 16:21
bf61714
to
307fe17
Compare
* Create document-agent's-general-description+purpose.md Documented the Agent's general description + purpose Signed-off-by: Esther Christopher <[email protected]> * Update document-agent's-general-description+purpose.md Effected the corrections. Signed-off-by: Esther Christopher <[email protected]> * minor fixes * move content into guide --------- Signed-off-by: Esther Christopher <[email protected]> Co-authored-by: Andrew Azores <[email protected]>
* update screenshots, fix some anchors * correct filenames * remove unnecessary paragraph tags * pluralize * clarify * simplify * singularize * fixup! singularize * fixup! fixup! singularize
… Basic mechanisms (#113) * doc(auth): remove outdated Bearer form, add details on OpenShift and Basic mechanisms Signed-off-by: Andrew Azores <[email protected]> * reflow * formatting * backtick quotes --------- Signed-off-by: Andrew Azores <[email protected]>
* docs(get-started): add information about the Agent and JMX config * typo * rephrase * quotes and typo * add anchors * openshift -> kubernetes * add note about maven registry auth * add comments * accept suggestion * typo * formatting * typo * formatting * break comment lines * use yaml multiline * plural * rephrase * add explanation comment * fixup! add explanation comment * rebase fix * list configuration combinations before explaining them * add links * rephrase * fix typo * fixup! fix typo * explain agent deployment environment variables more * explain cross-namespace Agent and Cryostat * reference agent version 0.2.1 * in hybrid agent setup, skip the jfr-jmx named port * set explicit hostname for JMX * reorganize
* chore(rules): update docs to mention Match Expression Visualizer * feat(topology): add docs for creating a custom target * feat(topology): document topology usage Signed-off-by: Thuan Vo <[email protected]> --------- Signed-off-by: Thuan Vo <[email protected]>
…erCryostat (#117) * docs(install): update installation information and images * update operator-sdk version * add table of contents * update step reference and links * add documentation about ClusterCryostat * split text into list * use usual default CR YAML for example * specify example's installation mode * distinguish OpenShift Console Topology View * cleanup outdated info * fixup! cleanup outdated info * correct screenshot * explain why CRs are namespace-specific * commas * remove outdated alternate operator installation methods * remove unused uninstallation steps * inline doc * point GitHub docs links to release branches, not latest development * add detail * comma * clarify one instance of Kubernetes-specific requirement * update olm instructions * syntax highlighting hints
* init commit Signed-off-by: Max Cao <[email protected]> * add mbean metrics, layouts/templates Signed-off-by: Max Cao <[email protected]> * fix widescreen -> fullscreen Signed-off-by: Max Cao <[email protected]> --------- Signed-off-by: Max Cao <[email protected]>
* chore(gem): add table-of-contents plugin * chore(blog): enable toc plugin on existing blog posts * feat(blog): add 2.3.0 release announcement post * link helm to specific release * add note about OLM * add link * comma * comma * set blog date
Can I get a final look-over and approval for this PR? All the changes have been individually reviewed. |
maxcao13
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
tthvo
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #102
Includes: